-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/os/mac: add tests to validate pkg-config library versions #8400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 👏🏻
Tested (and passing) on:
I can test on 10.13 High Sierra on one of the CI machines at some point. |
Could consider making it one of these things that actually runs on the CI machines (like the |
Possibly, though tests are mostly designed to ensure the pkg-config files are updated when things change in the OS, which won't happen for older OS versions. I suppose it could be tested when the tests themselves change - if that is expected to happen. |
Yeh, I guess I was thinking a test like this could be an easy way of avoiding manual verification. Could even be a (optional) |
The effects of a wrong version in the *.pc files are often extremely minor. I don't think we've ever had a bug report of anything caused by that. Something in |
@Bo98 Yeh my main thoughts are:
|
To clarify: although this test does have an |
I can remove that |
@Bo98 Lol simplecov. 🚢! |
Thanks again @Bo98! |
Coverage thing seems to be because codecov is picking the wrong base commit. We generate the coverage report on 27559050c83a84fb64167e3518d076adb3e9d7ec, and that's the commit that gets sent to codecov. It's a merge commit of 86eca5a into 6cde372, generated by GitHub ( |
@Bo98 Good catch, may be either needs a fix in the |
brew style
with your changes locally?brew tests
with your changes locally?These tests assume the needed SDKs are correctly installed, i.e.
brew doctor
passes.The CLT version installed should be the latest available for the running OS.
The tests do not check other OS versions beyond than the one the tests are being run on.
It is not possible to automatically check the following libraries for version updates:
Additionally, libffi version detection cannot be performed on systems running Mojave or earlier.
For indeterminable cases, consult https://opensource.apple.com for the version used.